[Bug 476460] Review Request: pymilter - Python interface to sendmail milter API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476460





--- Comment #17 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-01-29 12:34:33 EDT ---
For 0.9.0-4

* Unused macros
  - It seems that %python_sitelib is not used.

* Fedora/RHEL conditional
  - There are some useful macros, see:
    https://fedoraproject.org/wiki/Packaging/DistTag#Conditionals
    For example:
---------------------------------------------------------
%if 0%{?el3} || 0%{?el4}
%define __python python2.4
%endif
---------------------------------------------------------

* About version dependency
  - If you are to support both RHEL and Fedora by one spec file,
    then
----------------------------------------------------------
Requires: %{pythonbase} >= 2.4, sendmail >= 8.13
BuildRequires: ed, %{pythonbase}-devel >= 2.4, sendmail-devel >= 8.13
----------------------------------------------------------
    is sufficient
    (The reason I wrote that version dependency is redundant was
     that it is redundant just to support Fedora)

* python module dependency
  - Would you check if all needed dependencies related to python
    modules are included in Requires:
    For example, Milter/dns.py contains:
----------------------------------------------------------
     3  import DNS
     4  from DNS import DNSError
----------------------------------------------------------
    It seems this package should have "Requires: python-pydns".
    Also python-spf may be needed.

* Macros in %changelog
  - $ rpm -q --changelog pymilter shows:
----------------------------------------------------------
* Thu Jan 08 2009 Stuart Gathman <stuart at bmsi.com> 0.9.0-4
- Stop using INSTALLED_FILES to make Fedora happy
- Remove config flag from start.sh glue
- Own /var/log/milter
- Use /var <--------------------
----------------------------------------------------------
    that macros are expanded in %changelog. To prevent this,
    use %% (instead of %) in %changelog.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.