[Bug 482902] Review Request: gsh - aggregate several remote shells into one

bugzilla at redhat.com bugzilla at redhat.com
Thu Jan 29 18:21:31 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482902





--- Comment #5 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-01-29 13:21:30 EDT ---
God:
+ Duüöocated -n option was removed from %setup
+ Files stanza has no duplicated entries
+ egg-info directory was removed from source in the %setup stanza

Bad:
- the pity.py file is marked as execuatable, but all other files are not. I
think we should mark all files in %{python_sitelib}/gsh as nonexecutables. You
may remove the shebang line from the pity.py file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list