[Bug 481667] Review Request: xmlenc - XML output library for java.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481667


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #5 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-01-29 13:57:28 EDT ---
(In reply to comment #4)
> rpmlint also showed this non-standard-group error to me. I just looked at some
> other packages which used thos group tag. I was unsure whether non standard
> names are allowed or not.
  - Unless you have some reason you want to use the previous Group
    tag, I suggest to follow the suggestion from rpmint.

> Download url is fixed.
  - Note that wiki suggest
    http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tgz
    (middle "sourceforge" is not written)

> So when requiring explicitly icedtea I just use java(-devel) >= 1:1.6.0? 
    (please make it sure that you use epoch here)
  - I guess you wanted to say "openjdk" because on F-9/10/11 icedtea
    no longer exists. However, yes, with
    "(Build)Requires: java-devel >= 1:1.6.0" java-1.6.0-openjdk(-devel) is
    always selecteed, because "java-1.5.0-gcj(-devel)" does not satisfy
    this (Build)Requires.


Now looks good (however I suggest to modify the SourceURL a bit)
----------------------------------------------------------
    This package (xmlenc) is APPROVED by mtasaka
----------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.