[Bug 482965] Review Request: perl-XML-Generator - perl XML generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #6 from Parag AN(पराग) <panemade at gmail.com>  2009-01-30 01:03:30 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1092744
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
8f9e6ba2595b07997efac1377c5484e9  XML-Generator-1.01.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=132,  0 wallclock secs ( 0.03 usr  0.00 sys +  0.17 cusr  0.02
csys =  0.22 CPU)
+ Package perl-XML-Generator-1.01-3.fc11 =>
 Provides:
 perl(XML::Generator) = 1.01
 perl(XML::Generator::DOM) = 0.2
 perl(XML::Generator::DOM::util)
 perl(XML::Generator::cdata)
 perl(XML::Generator::comment)
 perl(XML::Generator::final)
 perl(XML::Generator::overload)
 perl(XML::Generator::pi)
 perl(XML::Generator::pretty)
 perl(XML::Generator::util)

Requires:
 perl(Carp)
 perl(XML::DOM)
 perl(XML::Generator)
 perl(base)
 perl(constant)
 perl(overload)
 perl(strict)
 perl(vars)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.