[Bug 483205] Review Request: eclipse-SystemTapGui - GUI interface for SystemTap

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483205


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |panemade at gmail.com




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-01-30 03:33:02 EDT ---
I have not done any java or eclipse related package review yet but let me try
this package for preliminary review.

1) you should use links for sourceforge as
http://nchc.dl.sourceforge.net/sourceforge/stapgui/eclipse-SystemTapGui.spec
http://downloads.sourceforge.net/stapgui/eclipse-SystemTapGui-1.0-1.fc10.src.rpm

2) Source0 should be
Source0:
http://downloads.sourceforge.net/stapgui/org.eclipse.SystemTapGui.src.tar.gz

3) From
http://fedoraproject.org/wiki/Packaging/EclipsePlugins#Specfile_Template, you
should have %install as

%install
rm -rf $RPM_BUILD_ROOT
install -d -m 755 $RPM_BUILD_ROOT%{_datadir}/eclipse/dropins/SystemTapGui
unzip -q -d $RPM_BUILD_ROOT%{_datadir}/eclipse/dropins/SystemTapGui \
build/rpmBuild/org.eclipse.SystemTapGui.systemtap.feature.zip


3) From
http://fedoraproject.org/wiki/Packaging/EclipsePlugins#Specfile_Template, you
should have %files as
%files
%defattr(-,root,root,-)
%{_datadir}/eclipse/dropins/SystemTapGui

See package built successfully with above changes
http://koji.fedoraproject.org/koji/taskinfo?taskID=1092915

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.