[Bug 481071] Review Request: tex-musixtex - Sophisticated music typesetting

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481071


Sarantis Paskalis <paskalis at di.uoa.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paskalis at di.uoa.gr
         AssignedTo|nobody at fedoraproject.org    |paskalis at di.uoa.gr
               Flag|                            |fedora-review?




--- Comment #1 from Sarantis Paskalis <paskalis at di.uoa.gr>  2009-01-30 05:10:52 EDT ---
Taking this review, since I own a couple of TeX font packages:

- Could you use the ctan archive for all the sources?

- Could you download the sources from the said archive with "wget -N" or
similar mechanism to preserve the timestamp on the files? (md5sums match)

- _texmf_main is declared in /etc/rpm/macros.texlive from texlive-texmf, so the
declaration -f _texmf is unnecessary. (btw if it is not a system macro, it
better not start with an "_").  I believe the "BuildRequires: kpsewhich" can go
as well after this.

- Could you please specify a little more explicitly the directories in the
files section?   The spec is correct as is, but the directory ownerships are
not obvious to review, especially in the future. (You can reuse the variables
MUSIXTEXDIR etc).

- I think the package should update the map files (running updmap-sys).  Please
see tetex-font-kerkis in F-10 (or ctan-kerkis-fonts, subpackage tex-kerkis) in
rawhide for an example.

No major problems found, fix the above and I will approve it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.