[Bug 479903] Review Request: gdesklet-slideshow - Cycle through a collection of pictures

bugzilla at redhat.com bugzilla at redhat.com
Fri Jan 30 10:24:37 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479903





--- Comment #15 from MERCIER <bioinfornatics at gmail.com>  2009-01-30 05:24:35 EDT ---
In first, thanks for you answer.

1/ Why did you change it...?

> %dir %{_datadir}/gdesklets/Controls/%{_ctrlname}
> %dir %{_datadir}/gdesklets/Displays/%{_appname}
> %{_datadir}/gdesklets/Controls/%{_ctrlname}/*
> %{_datadir}/gdesklets/Displays/%{_appname}/*
--------------------------------------------
someone on IRC #fedora-fr say is better.

i have upadte the spec file:
> %{_datadir}/gdesklets/Controls/ImageSlideShow/
> %{_datadir}/gdesklets/Displays/SlideShow/

2/ > %setup -q -n %{_appname}
> tar -xf %{SOURCE1} -C ../
--------------------------------------------
it's ok, i use %setup -q -c %{name}-%{version} -a1

3/ 
The LICENSE, MANIFEST, README and "todo" files are installed in addition to
%doc, and it is important to note that the LICENSE file must not be removed
from /usr/share/gdesklets/Displays/SlideShow/LICENSE - or else it cannot be
displayed by the desklet.
--------------------------------------------
ok, it's done

4/ 
Opening "Configure desklet" and selecting a folder from which to load images
always displays an error dialog:

| The folder contents could not be displayed
| 
| Operation not supported

It seems it always starts in the root directory due to that.
--------------------------------------------

yes i have the same error, i did'nt find the source code who make this error!

5/ they are no directory image 
i have see in Display/SideShow.script line 259:
Prefs.image_directory.value= value[:value.rfind( "/" )]
if you change the value by:
Prefs.image_directory.value= "/home/user/images"
is better.
but where put os.environ ['HOME']?

6/ i have update spec rpm and src rpm
http://bioinformatiques.free.fr/SlideShow-0.9-3.fc10.noarch.rpm

http://bioinformatiques.free.fr/SlideShow-0.9-3.fc10.src.rpm

http://bioinformatiques.free.fr/SlideShow.spec


7/ rpmlint:
$ rpmlint rpmbuild/SRPMS/SlideShow-0.9-3.fc10.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint rpmbuild/RPMS/noarch/SlideShow-0.9-3.fc10.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint rpmbuild/SPECS/SlideShow.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list