[Bug 483277] Review Request: nautilus-gdu - Nautilus extension for disk formatting

bugzilla at redhat.com bugzilla at redhat.com
Fri Jan 30 18:50:57 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483277





--- Comment #3 from Matthias Clasen <mclasen at redhat.com>  2009-01-30 13:50:57 EDT ---
package name: ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: ok
license file: ok
spec file language: ok
spec file legible: ok
sources: you should probably add a comment explaining how to get the tarball
from git. longer-term, we need to sort out hosting
buildable: ok
excludearch: ok
build deps: ok
locale handling: ok, no translations right now. sorting that out ties in to the
hosting question...
ldconfig: I don't think you need to call ldconfig in %post/%postun, since you
are not installing a shared library in the linker path, just a loadable module
relocatable: n/a
directory ownership: ok
duplicate files: ok
permissions: ok
%clean: ok
macro use: ok
permissible content: ok
large docs: n/a
%doc content: ok
headers: n/a
static libs: n/a
pc files: ok
shared libs: ok
devel subpackage: n/a
libtool archives: ok
gui apps: ok
file ownership: ok
%install: ok
utf8 filenames: ok

Summary: 
- add source comment
- remove unnecessary %post/%postun

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list