[Bug 483360] Review Request: pdfshuffler - PDF file merging, rearranging, and spliting

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483360


Milos Jakubicek <xjakub at fi.muni.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Milos Jakubicek <xjakub at fi.muni.cz>  2009-01-30 20:09:45 EDT ---
MUST:
+ rpmlint is silent
+ package name
+ spec file name
- packaging guidelines
  - "The summary should be a short and concise description of the package" 
    ? "A desktop diary" -- left from different spec file ? :)
+ Python guidelines:
  + defines %{python_sitelib}
  + builds egg from source
  + egg_info included
  + no unnecessary pyc/pyo
+ license (GPLv2+) ok, in COPYING as well in source files
+ spec file legible, English
+ source matches upstream (md5sum c59f3efcbc448c39fabbaac70c4237d4)
+ architectures ok (noarch)
+ builds in mock, no unnecessary BR
+ no need to ldconfig
+ locales ok (uses find_lang)
+ no library, hence no devel, static etc.
+ not relocatable
+ directories ownership ok
+ no dups in %files, proper %clean, %install
+ macros consistent
+ code and perm. content
+ %docs present
+ UTF-8

SHOULD:
+ license file
+ it works!:)

OTHERS:
- if you already insist on proper English grammar when patching (which is
great!), do it proper;)
  from the desktop file patch:
  "Comment=PDF Merging, Rearranging, and Spliting"
                                             ^
Provided that you fix the summary (and the patch typo:) when importing, this
package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.