[Bug 502692] Review Request: mingw32-libatomic_ops - MinGW Windows libatomic_ops compression library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502692


Erik van Pienbroek <erik-fedora at vanpienbroek.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |erik-fedora at vanpienbroek.nl
         AssignedTo|nobody at fedoraproject.org    |erik-fedora at vanpienbroek.nl
               Flag|                            |fedora-review?




--- Comment #1 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl>  2009-07-01 04:28:21 EDT ---
- Please change the %define tags at the top of the spec file with %global
(because of
http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define
)
- What does the patch libatomic_ops-1.2-ppclwzfix.patch do? According to the
filename I think it's some ppc-specific fix which doesn't have any effect on
Win32
- Is it true that this package only provides a static library and no shared
library (.dll) ? If that's the case, some special exceptions apply:
http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries
(however, we may need to interpret these slightly different as we don't use
-devel subpackages)
- The version number in the ChangeLog doesn't match the version specified in
the Version and Release tags

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.