[Bug 503297] Review Request: panoglview - Immersive viewer for spherical panoramas

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503297


Nicolas Chauvet (kwizart) <kwizart at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |kwizart at gmail.com
         AssignedTo|nobody at fedoraproject.org    |kwizart at gmail.com
               Flag|                            |fedora-review?




--- Comment #3 from Nicolas Chauvet (kwizart) <kwizart at gmail.com>  2009-07-01 11:18:21 EDT ---
- starting review -

OK - rpmlint panoglview is quiet on installed package
OK - build in mock (fedora 11 x86_64 )

NEEDWORK - You aren't expected to run:
update-mime-database %{_datadir}/mime
Because this package doesn't bring any new mime type. But indeed
update-desktop-database is mandatory since the .desktop file use a MimeType=
field. As said:
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database

By the way, using || : at the end of each scriptlet filters the error code if
anything went wrong. So this only makes sense for the last line:
example :
first command &> /dev/null 
second command  &> /dev/null || :

That way, the rpm transaction will continue, even if update-desktop-database
failed.

NEEDWORK - License match source code : GPLv2+ but COPYING text is about GPLv3.
This would need clarification

NEEDWORK - url field cannot permit to download the source tarball (is it the
right url ?)

USABILITY test: I'm experiencing some refresh delay when moving the sphere.
I will try to reproduce on another workstation.
(Is it expected to see only from the inside despite of the outside of the
sphere ?)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.