[Bug 492203] Review Request: frinika - Music Workstation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492203





--- Comment #9 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-07-01 15:56:55 EDT ---
(In reply to comment #8)
> (In reply to comment #7)
> 
> > The patch is not needed for the SevenZip that is in the frinika tarball. It 
> > is specific for the SevenZip we have in Fedora.
> If bundled SevenZip is not used anymore, you really need this patch?
> 
The patch is applied to frinika source that make the call to SevenZip library.
It doesn't directly patch SevenZip.

The SevenZip is bundled in frinika's source and frinika doesn't need the patch
if it uses this bundled source. However we are not using the SevenZip that
comes with frinika. Instead, we are using Fedora's SevenZip. In order to use
Fedora's SevenZip we need to patch frinika sources. This is what the patch is
for.

> 
> As I can understand it, it is about adding paths into CLASSPATH manually, not
> create symlinks.
> 
> I'm not very similar with java (as you already known), sorry if it is not
> correct.
> 

There are two ways of handling this:
With build-classpath or with build-jar-repository
The build system of frinika (the build.xml stuff) looks into the directory lib/
and adds the jar files in this directory to classpath. So I use
build-jar-repository for this purpose.

I could also use build-classpath, but this will require a bigger modification
of the build system of frinika. We don't really need that.

The difference is explained in
   http://fedoraproject.org/wiki/Packaging:Java#build-classpath

> 
> Meanwhile, on current stage some additional notes:
> 1) lib directory in tarball contains many binary jars and even library .so. It
> is needed? I'm still do not do any investigation, but you are assured tha 
> don't used in build? What all built from sources? May be safely remove such 
> binaries in our svn-fetch script?

In the fetch script, I only remove the parts that are known to be nonfree. The
rest of .so, .jar, .exe binaries is removed in %prep to make sure that we are
not using them.

> 2) Just for note: In fetch script in "latest" option first fetch last revision
> number to provide in -r option of svn. It is excessive. There may be HEAD. Or
> just this key ommited (how you was used it in "svn co" previous). Like:
> if [ 'latest' == "$1" ]; then
> REV="-rHEAD" # OR just REV=""
> else
> REV="-r$1"
> fi
> ....
> svn export $REV ....

But I can't get the revision number to append to the filename this way. i.e.
$ sh frinka-snapshot.sh latest
---> frinika-550.tar.bz2
Is there another way?

> 3) I see comment about all other sources. But what about fetch instruction to
> Source0 (about what script with what parameter must be used)?

I believe that I have been quite verbose in terms of comments. Also the fetch
script gives an output for usage. I don't think we need more. There is no room
for confusion.

> 4) You remove DKnode, nice. But petersalomonsen component stil here.

Upstream responded that all these sources
   petersalomonsen
   src/uk/ac/bath/*
are all written by them and they are going to be maintained in frinika. We
don't need to package them separately.

> 5) Just intresting:
> # Remove some unneded sources
> rm -fr src/uk/ac/bath/gui/vamp/KnobWidget.java
> rm -fr src/uk/ac/bath/gui/vamp/VAmp2Editor.java
> for what them? Is there any legal issues? It is break build?
> 
> 

It broke the build. However:

After my email, they removed
   DKnode
   src/uk/ac/bath/gui/vamp/
from their sources since they are not using them. So I packaged svn revision
550 with these sources removed.

Ref: https://sourceforge.net/forum/forum.php?thread_id=3319021&forum_id=447356


SPEC: http://oget.fedorapeople.org/review/frinika.spec
SRPM: http://oget.fedorapeople.org/review/frinika-0.5.1-5.550svn.fc11.src.rpm

changelog 0.5.1-5.550svn
- Update to svn revision 550


I think that everything you mentioned is addressed now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.