[Bug 502130] Review Request: openocd - Open On-Chip Debugger

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502130





--- Comment #5 from Dean Glazeski <dnglaze at gmail.com>  2009-07-01 20:35:13 EDT ---
(In reply to comment #4)
> #1: The contents of /usr/share/openocd/contrib should go to %doc
> %doc contrib/
>
> and remove the /usr/share/openocd/contrib at the end of the %install section to
> avoid duplicates

This makes more warnings appear from rpmlint.  For some reason, doing the
"fuller path" %doc %{_datadir}/%{name}/contrib/* results in no warnings.

> #2: source url should be complete

I think I got this done.  I replaced the URL parameter with the full path to
the source tar on OpenOCD's project site.

> #3: Preserve timestamps
> add INSTALL="install -p"  to your make install  

Added this.

New links:
http://files.dinoprojects.com/openocd/openocd-0.1.0-2.fc10.src.rpm
http://files.dinoprojects.com/openocd/openocd.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.