[Bug 507621] Review Request: pypoppler - Python bindings for the Poppler PDF rendering library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507621


Juan Manuel Rodriguez <nushio at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nushio at fedoraproject.org




--- Comment #7 from Juan Manuel Rodriguez <nushio at fedoraproject.org>  2009-07-02 22:16:10 EDT ---
Hi Hicham, 

One of the first things you should do to any specfile, is run rpmlint on it. 

rpmlint will show any errors or warnings there are on your Specfile, like mixed
use of spaces and tabs. 

rpmlint said: 
pypoppler.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 20)

Also, what Leigh said about the Static Libraries is right. 
On %configure, use --disable-static

and on %install, remove the la file, using: 
rm -rf $RPM_BUILD_ROOT%{python_sitelib}/*.la

I updated your specfile with these changes. 
http://proyectofedora.org/mexico/pypoppler.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.