[Bug 509521] Review Request: perl-CGI-Application-Plugin-TT - Add Template Toolkit support to CGI::Application
bugzilla at redhat.com
bugzilla at redhat.com
Fri Jul 3 09:59:14 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=509521
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |panemade at gmail.com
AssignedTo|nobody at fedoraproject.org |panemade at gmail.com
Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2009-07-03 05:59:13 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1452265
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
8457506a05277b125cb3f8367150ff8f3c97a4f5 CGI-Application-Plugin-TT-1.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=11, Tests=61, 3 wallclock secs ( 0.09 usr 0.03 sys + 2.56 cusr 0.16
csys = 2.84 CPU)
+ Package perl-CGI-Application-Plugin-TT-1.04-1.fc12.noarch =>
Provides: perl(CGI::Application::Plugin::TT) = 1.04
Requires: perl(CGI::Application) >= 4.0 perl(Carp) perl(Exporter)
perl(File::Spec) perl(Scalar::Util) perl(Template) >= 2.0 perl(strict)
perl(vars)
+ Not a GUI application
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list