[Bug 507377] Review Request: jana - An interface library for time-related PIM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507377





--- Comment #2 from Peter Robinson <pbrobinson at gmail.com>  2009-07-03 07:17:52 EDT ---

> jana.i586: W: incoherent-version-in-changelog 0.4.5-0.1
> ['0.4.5-0.1.20090622gitb416a41.fc12', '0.4.5-0.1.20090622gitb416a41']
> ==> Fix this

Fixed. My understanding was that it was fine to shorten those versions to just
the build number

> Suggestions:
> 1) you don't need 
> BuildRequires: glib2-devel as it will be pulled by gtk2-devel

Fixed

> 2) It will be always good to use make install as
> make install DESTDIR=%{buildroot} INSTALL="install -p"
> this will make sure you will keep timestamps of upstream files that are copied
> as it is.

Not seen that in the package guidelines. 

> 3) Add documentation like you added for mojito

Done

> 4) I am not sure whether we can have some more additional subpackages like
> libjana-gtk and libjana-ecal
> Do you think we can have them separate?

We can if there's a demand. I'm not sure what the advantage is as its a small
set of libraries. It can easily be split out later if there's a demand.

SRPM:
http://pbrobinson.fedorapeople.org/jana-0.4.5-0.2.20090622gitb416a41.fc11.src.rpm
SPECS: same as before.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.