[Bug 492816] Review Request: squeal - A SQL-like interface for the command line

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492816


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




--- Comment #13 from Jason Tibbitts <tibbs at math.uh.edu>  2009-07-03 16:02:50 EDT ---
I finally found some time to make it back to this package; sorry for taking so
long.  This one builds fine and rpmlint is silent.

Generally there's no point in mentioning the name of the package in the
summary.  There's a group trying to clean these up; there's little point in
adding another for them to fix.

It would be nice to elaborate just a bit in the %description.  One gets the
impression that this package is something akin to mysqlclient, but in reality
it's very far from that.  I'd at least mention that it can parse log files and
allow you to make sql-like queries on them.

I'm supposed to ask you to bug upstream to include the text of the license.  In
this case I guess I'm just bugging you directly.

* source files match upstream.  sha256sum:         
   a5aa0e8a938f786cd78678cae98f0033565a95b4cc80af36d052244b73b542d8
   squeal-0.4.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
? summary could use a tweak.
? description could use some elaboration.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   squeal = 0.4-3.fc12
  =
   /usr/bin/python
   python(abi) = 2.6
   python-augeas

* %check is not present; no upstream test suite.  I installed and tested this a 
  bit and it seems to work fine.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.