[Bug 508750] Review Request: trash-cli - Command line interface to the freedesktop.org trashcan

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508750


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at christoph-wickert.de




--- Comment #5 from Christoph Wickert <fedora at christoph-wickert.de>  2009-07-04 10:16:03 EDT ---
Some more comments:

* URL should be http://trash-cli.googlecode.com/

* License is GPLv2+, take a look at the headers of the scripts ("...any later
version").

* Try to preserve timestamps when modifying files in %prep. Can be done similar
to 
https://fedoraproject.org/wiki/PackageMaintainers/PackagingTricks#Convert_encoding_to_UTF-8

* Timestamp of Source0 does not match

* Most of the docs are missing, at least AUTHORS and COPYING *must* to be
included in the package

* What's the use of this?
  install -d $(dirname %{buildroot}%{_mandir})
  mv %{buildroot}/usr/man %{buildroot}%{_mandir}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.