[Bug 474802] Review Request: vacation - Automatic mail answering program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474802


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi




--- Comment #9 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-05 16:31:25 EDT ---
- The 
 -n %{name}-%{version}
in %setup is redundant, as it is the default setup path.

- Any reason why SMP make is not enabled? If it doesn't work, document it with
a comment in the spec file.

- Use the -p argument in all of the install commands. (At least for the files
that are not generated in the %build phase.)

- The %post and %trigger stuff seems very cumbersome. Two easier possibilities
come to mind:
Create the symlinks in %install and make the package own them. Additionally,
for the dir ownership:
1) Require sendmail, which provides the directory. [If the package works also
with postfix, exim &c then this is not adviseable.]
2) Make the package own the /etc/smsrh/ directory. [This creates a double
provides, but a necessary one.]

Or, you could even put the symlinks in a subpackage, say vacation-sendmail,
which would require sendmail and own the symlinks.

- You might want to change
 %{_mandir}/*/*
to
 %{_mandir}/man1/*.1
to be a bit more precise, or even list the two files explicitly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.