[Bug 509533] Review Request: sap - A small CLI audio player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=509533


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi




--- Comment #3 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-06 09:11:25 EDT ---
- Don't run the build any more in %install: drop the line
 sh ./build

- Instead of running
 mkdir -p %{buildroot}%{_bindir}
 cp -p sap %{buildroot}%{_bindir}
 mkdir -p %{buildroot}%{_defaultdocdir}/%{name}-%{version}
 mkdir -p %{buildroot}%{_mandir}/man1
 cp -p sap.1 %{buildroot}%{_mandir}/man1
you could just
 install -D -p -m 755 sap %{buildroot}%{_bindir}/sap
 install -D -p -m 644 sap.1 %{buildroot}%{_mandir}/man1/sap.1

- You could do with a bit of space inbetween spec file sections.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.