[Bug 509965] Review Request: snmptt - SNMPTT (SNMP Trap Translator) is an SNMP trap handler written in Perl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=509965


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841(FE-NEEDSPONSOR)      |




--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-07 06:22:51 EDT ---
(You don't need the NEEDSPONSOR tag since I've already agreed to sponsor you.)

- Drop "SNMPTT (SNMP Trap Translator) is" from the summary.

- Change the Requires: /sbin/chkconfig to Requires: chkconfig.

- The character set conversion should be
 iconv -f ISO-8859-1 -t UTF-8 ChangeLog > ChangeLog.utf8 && \
 touch -r ChangeLog ChangeLog.utf8 && \
 mv ChangeLog{.utf8,}

- Drop the
 exit 0
from %build.

- %{_initdir} should be %{_initddir}. What's the idea behind the following??
 %if 0%{?rhel} > 5 || 0%{?fedora} > 9
 install -D -p -m 0755 snmptt-init.d %{buildroot}%{_initdir}/snmptt
 %else
 install -D -p -m 0755 snmptt-init.d %{buildroot}%{_initrddir}/snmptt
 %endif


- You can use install to create directories as well with "install -d
/path/to/dir"

- Use the standard script to create the user
https://fedoraproject.org/wiki/Packaging/UsersAndGroups

- Same thing for the initscript stuff
https://fedoraproject.org/wiki/Packaging/SysVInitScript

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.