[Bug 508836] Review Request: colossus - computer implementation of Titan

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508836


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




--- Comment #17 from Jason Tibbitts <tibbs at math.uh.edu>  2009-07-07 14:49:34 EDT ---
I'll go ahead and take this for review, and eventually sponsor you when we get
to that point.  I'll wait until you have that new package up before doing a
full review, but I can make a few comments:

The package in comment 13 does build OK; the javadoc package still comes out
empty but I suppose you're still working on that.  The AOT bits compile OK
(with proper debuginfo generated) and everything looks to be in the proper
place.  I'll install and test this when I get home.

The package versioning isn't proper, however.  First, is the version really
"20090701" or is that just a snapshot date?  I don't see that any version
20090701 was ever released, so it seems that you've just made that version up. 
Has upstream ever made an actual versioned release?  Do you expect that in the
future they will release version 1.0?

I suggest you peruse the Naming Guidelines, specifically
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages

My guess is that upstream hasn't actually released any versioned tarball, and
so you'd just use a version of 0, making the proper NVR 
  colossus-0-0.1.20090701svn4427
(that's a pre-release snapshot).

If the last downloadable file is really versioned 20081029 and you know that
they intend to use dates for versioning in the future:
  colossus-20080129-1.20090701svn4427
(that's a post-release snapshot).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.