[Bug 504473] Review Request: rubygem-rubigen - A framework to allow Ruby applications to generate file/folder stubs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504473





--- Comment #6 from Lubomir Rintel <lkundrak at v3.sk>  2009-07-08 12:21:31 EDT ---
(In reply to comment #5)
> Some notes for 1.5.2-3:
> 
> * License tag
>   - As website/javascripts/rounded_corners_lite.inc.js is under
>     LGPLv2+, license tag should be "MIT and LGPLv2+".

Fixed

> * Requires
>   - rubygem(hoe) doesn't seem to be needed. Would you check this?

Good Catch. It was needed merely for rebuild, which we don't do.

> * Test
>   - I think as this gem file contains test/ directory, it is preferable
>     to add %check section and execute some tet program there
>     (another gem seems needed, though)

I would prefer not running the test suite unless absolutely necessary. They
seem use rather exotic and poorly-estabilished testing tool chain -- mocha for
api mocking and shoulda for just having an extra dependency. I would be really
happy if we didn't have to package these, and their dependency chain for Fedora
now.

> By the way, I would appreciate it if you would review my
> review requests (bug 508416 or bug 508417, both are rubygem related)  

Of course, will do. Sorry for the long delay, I'm going to look into those
right now.

SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-rubigen.spec
SRPM:
http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-rubigen-1.5.2-4.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.