[Bug 508453] Review Request: rubygem-test-spec - Behaviour Driven Development interface for Test::Unit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508453





--- Comment #2 from Lubomir Rintel <lkundrak at v3.sk>  2009-07-08 13:01:09 EDT ---
(In reply to comment #1)

> work to do:
> - package is distributed in the same terms as ruby is. So it should have ruby
> license or GPLv2. Not GPLv2+.

Good catch. Fixed.

> - Consistent build root reference. In %clean stare it's referred to build root
> as %{buildroot} and other stages uses $RPM_BUILD_ROOT.

Fixed.

> - add BuildRequires: ruby(abi) = 1.8 (maybe should be checked by rpmlint)

bug #510313

SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-test-spec.spec
SRPM:
http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-test-spec-0.10.0-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.