[Bug 508417] Review Request: rubygem-ruby-opengl - OpenGL Interface for Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508417


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?




--- Comment #2 from Lubomir Rintel <lkundrak at v3.sk>  2009-07-08 13:33:50 EDT ---
(In reply to comment #1)
> By the way the naming seems a bit strange, however gem name is
> actually called as "ruby-opengl" so I think "rubygem-ruby-opengl" is
> proper for srpm name.  

Definitely.

* Named correctly
* SPEC file clean, legible and in american english
* license correct
* builds fine in mock
* Proper compiler flags used
* filelists sane
* require/provide list seems sane

Tip: You may want to fill in the %check section with the testsuite executed
conditionally (e.g. prepend it with [ "$DISPLAY" ] || exit 0), so that the
maintainer (you) can run the tests in his development setup before sumbitting
the package into the build system.

APPROVED

(please don't import/build before the minor concerns from the dependency
package are addressed and it is approved as well)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.