[Bug 508416] Review Request: rubygem-mkrf - Making C extensions for Ruby a bit easier

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508416





--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-07-08 14:13:22 EDT ---
Thank you for review.

(In reply to comment #1)
> * spec file clean and legible
>   (well, you could improve indentation in %globals paragraph :)
- Perhaps now it should look better.

> 2.) Rpmlint
> 
> rubygem-mkrf.noarch: E: non-readable
> /usr/lib/ruby/gems/1.8/cache/mkrf-0.2.3.gem 0600
> 
> You probably want to change this via %attr in %files or change the mode in
> %install or something.  
- Fixed.

http://mtasaka.fedorapeople.org/Review_request/rubygem-mkrf/rubygem-mkrf.spec
http://mtasaka.fedorapeople.org/Review_request/rubygem-mkrf/rubygem-mkrf-0.2.3-2.fc.src.rpm

* Thu Jul  9 2009 Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> - 0.2.3-2
- Improve indentation
- Make sure gem is installed with proper permission

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.