[Bug 491694] Review Request: Anyterm - Web based terminal emulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491694





--- Comment #17 from Mohammed Morsi <mmorsi at redhat.com>  2009-07-08 15:06:22 EDT ---
Apologize for the long delay, I have been very busy with other tasks.

I made changed to address all of the remaining issues raised above. The new
spec / srpm can be found here:
http://mohammed.morsi.org/blog/files/anyterm.spec
http://mohammed.morsi.org/blog/files/anyterm-1.1.29-4.fc10.src_.rpm

Please note the following:

- as far as the executable stack in anytermd issue
   'export CFLAGS="$RPM_OPT_FLAGS"' did not fix the issue
    adding "execstack -c anytermd" after the make in the build section fixes
this
     but I'm not sure if thats the ideal solution

- removed the small patch I had added to parameterize the url vars per your
concerns that it isn't upstream

-  Doesn't build on rawhide i386 issue: 
     I was unable to get a rawhide system working 
        (installed F11, enabled rawhide repo, updated, restarted, boot sequence
crashed w/ a stack trace)
     I could not reproduce this, on a regular non-rawhide F11 i386 vm
       Here is the output:  http://ovirt.pastebin.com/m570a2b2
     Is this a major issue, it is rawhide after all

- Latest Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1460119

- Current rpmlint output: 
     $ rpmlint RPMS/x86_64/anyterm-1.1.29-4.fc10.x86_64.rpm 
        anyterm.x86_64: W: unstripped-binary-or-object /usr/sbin/anytermd
        1 packages and 0 specfiles checked; 0 errors, 1 warnings.

- rpmlint reports "anyterm.x86_64: W: unstripped-binary-or-object
/usr/sbin/anytermd", 
     couldn't find much info on this and adding "-i" to rpmlint didn't help

- had to introduce DEFAULT_LOCKFILE to init script as rpmlint reported (without
it)
    "anyterm.x86_64: E: incoherent-subsys /etc/rc.d/init.d/anyterm anyterm}"
(note trailing brace)

- Clarification needed for your comments:
     "BuildRoot is wrong. Easy fix."
      "Whitespace mismatch in tags"
      (are these still issues?)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.