[Bug 491694] Review Request: Anyterm - Web based terminal emulator

bugzilla at redhat.com bugzilla at redhat.com
Thu Jul 9 15:00:08 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491694





--- Comment #19 from Mohammed Morsi <mmorsi at redhat.com>  2009-07-09 11:00:06 EDT ---
Thanks for the feedback, I tried changing the spec to incorporate cflags / cxx
flags as you suggested like so:

%build
export CFLAGS="$RPM_OPT_FLAGS"
export CXXFLAGS="$RPM_OPT_FLAGS"
make %{?_smp_mflags} CFLAGS="$CFLAGS" CXXFLAGS="$CXXFLAGS"
%{__gzip} anytermd.1
#execstack -c anytermd

Unfortunately after building / running rpm lint on it both the
unstripped-binary-or-object and executable stack (note I commented out
execstack) issues persisted.

Looking at the 1.1.29 makefile
http://svn.anyterm.org/anyterm/tags/releases/1.1/1.1.29/common.mk  the issue
might be that the author explicitly sets CPP_FLAGS, overwriting it if
previously set, and doesn't use CFLAGS or CXXFLAGS at all.

Then again, trying the rpmbuild process w/ ${RPM_OPT_FLAGS} explicitly set and
passed to each invocation of g++ doesn't seem to resolve either of the issues
(but does add "-02 -g" to the g++ command)

Still not sure what I need do to resolve this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list