[Bug 502490] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502490





--- Comment #3 from Michal Ingeli <mi at v3.sk>  2009-07-09 15:47:01 EDT ---
(In reply to comment #2)
> (In reply to comment #1)
> > - bad license. should be MIT [1] 
> Fixed.

OK

> > - missing require for ruby(abi)
> Fixed. 

OK

> > - file listed twice
> >   warning: File listed twice:
> > /usr/lib/ruby/gems/1.8/gems/state_machine-0.7.4/LICENSE

You can see this warning at the end of build.log [1].

> > - rubygem-state_machine.src: W: mixed-use-of-spaces-and-tabs (spaces: line 33,
> > tab: line 7)
> 
> Hmmm. I don't see this error. I did a scratch build, then downloaded and ran
> rpmlint on the RPM and saw no complaints. Can you tell me how you produced
> this?
> 
> (mcpierce at mcpierce-laptop:rubygem-state_machine)$ rpmlint
> ~/Download/rubygem-state_machine-0.7.4-2.fc11.noarch.rpm 
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

You should run rpmlint on both result rpm and src rpm. This warning is from src
rpm.

> Updated spec: http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine.spec
> Updated SRPM:
> http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine-0.7.4-2.fc11.noarch.rpm

(note, this is not srpm)

> Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1446813  

[1] http://koji.fedoraproject.org/koji/getfile?taskID=1446816&name=build.log

sorry for late response

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.