[Bug 456684] Review Request: pathfinder - X.509 Path Discovery and Validation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456684





--- Comment #6 from Dan Horák <dan at danny.cz>  2009-07-10 07:01:16 EDT ---
Doing a full review after such long time, see comments at the end of the
check-list.

OK* source files match upstream:
     6bdd0eaae0b2e1240023335398bd7c84dce88e36  pathfinder-1.0.0-Source.tar.gz
BAD package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible (LGPLv2+). License text included in
package.
OK latest version is being packaged.
OK BuildRequires are proper.

OK compiler flags are appropriate.
OK %clean is present.
OK* package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK* rpmlint is silent.
OK final provides and requires look sane.
BAD %check is present and all tests pass.
OK shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present (shared libs, new user, service).
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers in -devel.
OK pkgconfig files in -devel.
OK no libtool .la droppings.
OK not a GUI app.

- googlecode return 404 when trying to download the sources, but in few times I
was successful, strange ...
- why Release == 0.2 when 1.0.0 is a regular release, not a pre-release
- it builds with the check section disabled
- checks don't run in a chrooted environment (in mock)
- rpmlint complains a bit, but it's harmless and expected
pathfinderd.x86_64: W: non-standard-uid /var/run/pathfinderd pathfinderd
pathfinderd.x86_64: W: non-standard-gid /var/run/pathfinderd pathfinderd
pathfinderd.x86_64: W: incoherent-subsys /etc/rc.d/init.d/pathfinderd $prog

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.