[Bug 509856] Review Request: qrencode - The libqrencode library and application encodes QR Code symbols (2d barcodes)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=509856


Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |steve.traylen at cern.ch




--- Comment #1 from Steve Traylen <steve.traylen at cern.ch>  2009-07-10 10:10:00 EDT ---
Hi Bowe,

This is an unofficial review:

rpmlint of spec file:

$ rpmlint qrencode.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

Building the package:

1) checking pkg-config is at least version 0.9.0... yes
  checking for png... configure: error: Package requirements ("libpng12")
  were not met:

  No package 'libpng12' found

   After installing "libpng-devel" it completes so should be added to the
   BuildRequires of course.

2) Rpath errors. If you add 

%__arch_install_post   /usr/lib/rpm/check-rpaths   /usr/lib/rpm/check-buildroot

to your ~/.rpmmacros  which you do by running "rpmdev-setuptree" then
you get the following...


ERROR   0001: file '/usr/bin/qrencode' contains a standard rpath '/usr/lib64'
in [/usr/lib64]
error: Bad exit status from /var/tmp/rpm-tmp.6ynHaY (%install)

See:

http://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath

for explanation.

Steve

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.