[Bug 447368] Review Request: schroot - Execute commands in a chroot environment

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=447368


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




--- Comment #15 from Jason Tibbitts <tibbs at math.uh.edu>  2009-07-11 03:07:45 EDT ---
Well, that was a bust.  At this point I'm of the opinion that yes, this is
potentially problematic, but we aren't installing on everyone's system by
default and if there's a problem we can deal with it.  Honestly a review ticket
shouldn't have to sit around for fourteen months anyway.

So, I have some time so I'm going to go ahead and work on this.

Here's the latest rpmlint output:

  dchroot.x86_64: E: non-standard-executable-perm /usr/bin/dchroot 04755
  schroot.x86_64: E: non-standard-executable-perm /usr/bin/schroot 04755
  dchroot.x86_64: E: setuid-binary /usr/bin/dchroot root 04755
  schroot.x86_64: E: setuid-binary /usr/bin/schroot root 04755
These are OK; being setuid is kind of necessary.

  schroot.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libsbuild.so.1.0.0 
   /lib64/libm.so.6
  schroot.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libsbuild.so.1.0.0 
   /usr/lib64/libboost_filesystem.so.5
  schroot.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libsbuild.so.1.0.0 
   /usr/lib64/libboost_program_options.so.5
The indicated library is linked against those three libraries without actually
calling anything in them.  This is common with libtool-using packages.  It's
not an especially big deal, but you can find some info on making it go away at
http://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency

  schroot.x86_64: E: library-without-ldconfig-postin
   /usr/lib64/libsbuild.so.1.0.0
  schroot.x86_64: E: library-without-ldconfig-postun
   /usr/lib64/libsbuild.so.1.0.0
You must call ldconfig when installing shared libraries into system locations.
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries

  dchroot.x86_64: E: binary-or-shlib-defines-rpath
   /usr/bin/dchroot ['/usr/lib64']
  schroot.x86_64: E: binary-or-shlib-defines-rpath
   /usr/bin/schroot ['/usr/lib64']
  schroot.x86_64: E: binary-or-shlib-defines-rpath
   /usr/libexec/schroot/schroot-listmounts ['/usr/lib64']
  schroot.x86_64: E: binary-or-shlib-defines-rpath
   /usr/libexec/schroot/schroot-mount ['/usr/lib64']
  schroot.x86_64: E: binary-or-shlib-defines-rpath
   /usr/libexec/schroot/schroot-releaselock ['/usr/lib64']
These need fixing, and unfortunately passing --disable-rpath to %configure
didn't help.  There's some info at
http://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath

Some other random comments:

The description for the dchroot package could use a bit more elaboration.

I think the license is GPLv3+, not GPLv3 only.  Do you see some place where the
version is limited to v3?

Nothing owns /etc/schroot, /etc/schroot/exec.d, /etc/schroot/setup.d,
/usr/libexec/schroot or /var/lib/schroot.

That's enough for now.  If you get those fixed up I'll do a complete review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.