[Bug 502490] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502490





--- Comment #6 from Darryl L. Pierce <dpierce at redhat.com>  2009-07-11 10:42:48 EDT ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > > > - file listed twice
> > > > >   warning: File listed twice:
> > > > > /usr/lib/ruby/gems/1.8/gems/state_machine-0.7.4/LICENSE
> > > 
> > > You can see this warning at the end of build.log [1].
> > 
> > I'm not sure what the issue is there. The spec file does not mention it more
> > than once, and the file only shows up once in the gem itself. Any
> > recommendation on how to proceed, and is this a blocker for review?
> 
> Yes, it is a blocker. According to [1][2] files can be listend only once. It's
> quite easy fix. You should replace the "%{gemdir}/gems/%{gemname}-%{version}/"
> entry with "dir %{geminstdir}" and list all entries in that directory
> separately. Just note that examples, tests, rdoc and so should be listed as
> %doc.
> 
> [1] https://fedoraproject.org/wiki/Packaging/ReviewGuidelines#cite_ref-12
> [2] https://bugzilla.redhat.com/show_bug.cgi?id=504469#c7  

Thanks for the advice. I've fixed the aforementioned bugs in the srpm and rpm,
and both check out clean for me:

Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine.spec
Updated SRPM:
http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine-0.7.4-3.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.