[Bug 510839] Review Request: qrupdate - A Fortran library for fast updates of QR and Cholesky decompositions

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510839


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review+




--- Comment #2 from Jason Tibbitts <tibbs at math.uh.edu>  2009-07-11 11:03:27 EDT ---
rpmlint output is actually:
  qrupdate-devel.x86_64: W: no-documentation
not a problem

  qrupdate.x86_64: W: unused-direct-shlib-dependency /usr/lib64
   /libqrupdate.so.1.0 /lib64/libm.so.6
  qrupdate.x86_64: W: unused-direct-shlib-dependency /usr/lib64
   /libqrupdate.so.1.0 /lib64/libgcc_s.so.1
The library is linked against other libraries that it does not use.  You have
to install the rpm and then do "rpmlint qrupdate" to see these.  I don't think
these are problematic; it's not as if those libraries won't be linked in for
some other reason.

I'm surprised there's nothing like a header, but I guess that's Fortan.  You
just call the functions and hope you get the arguments the right way 'round.

* source files match upstream.  sha256sum:
   45ba0b4e6b15236a219b5b380e15fc9acfe6760a9ca5e53484de9b534969ba0d  qrupdate-
    1.0.1.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.                                                              
* description is OK.                                                          
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
  qrupdate-1.0.1-1.fc12.x86_64.rpm
   libqrupdate.so.1()(64bit)
   qrupdate = 1.0.1-1.fc12
   qrupdate(x86-64) = 1.0.1-1.fc12
  =
   /sbin/ldconfig
   libblas.so.3()(64bit)
   libgcc_s.so.1()(64bit)
   libgfortran.so.3()(64bit)
   libgfortran.so.3(GFORTRAN_1.0)(64bit)
   liblapack.so.3()(64bit)
   libqrupdate.so.1()(64bit)

  qrupdate-devel-1.0.1-1.fc12.x86_64.rpm
   qrupdate-devel = 1.0.1-1.fc12
   qrupdate-devel(x86-64) = 1.0.1-1.fc12
  =
   libqrupdate.so.1()(64bit)
   qrupdate = 1.0.1-1.fc12

* %check is present and all tests pass:
   TOTAL:     PASSED 112     FAILED   0

* shared libraries are installed:
   ldconfig is called properly.
   unversioned .so link is in the -devel package.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files.
* scriptlets are OK (ldconfig).
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.