[Bug 510729] Review Request: pkcs11-helper - A library for using PKCS#11 providers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510729





--- Comment #2 from Kalev Lember <kalev at smartlink.ee>  2009-07-11 15:17:42 EDT ---
Thanks for your review!

> I wonder if upstream realizes that they're supposed to replace "<ORGANIZATION>"
> in their license text with either their names or the name of their
> organization.  Without doing that the provision is essentially void and they
> might just as well use the 2-clause BSD or the MIT license.

I notified Alon Bar-Lev by email and also added opensc-devel mailing list to
CC:
http://www.opensc-project.org/pipermail/opensc-devel/2009-July/012311.html


> rpmlint says:
>   pkcs11-helper.x86_64: W: unused-direct-shlib-dependency
>    /usr/lib64/libpkcs11-helper.so.1.0.0 /lib64/libz.so.1
> I guess the openssl pkgconfig files mandate that everything link against zlib,
> even if nothing in zlib is being called.   You can clean this up if you like,
> but it's not really a problem.

The warning looks harmless enough that I guess I'm going to leave it as it is.


> It looks like /usr/share/aclocal is unowned.  This package needs to depend on
> automake if it's going to put files there.

Added automake dependency to devel subpackage:
Spec URL: http://www.smartlink.ee/~kalev/pkcs11-helper.spec
SRPM URL: http://www.smartlink.ee/~kalev/pkcs11-helper-1.07-2.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.