[Bug 506429] Review Request: eclipse-eclox - Eclipse-based doxygen plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506429


Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Remi Collet <fedora at famillecollet.com>  2009-07-12 04:04:53 EDT ---
> I was unable to find the sources of eclo, except compiled jars from upstream.
> Hence I pull the sources from svn.
I've also search in SVN and don't find any usefull tag :(

Should ask upstream (for future release) to provide a source tarball or simply
a SVN tag.



REVIEW : 

+ RPMLINT is ok
eclipse-eclox-0.8.0-2.20090616svn.fc8.noarch.rpm
eclipse-eclox.src: I: checking
eclipse-eclox.src: W: strange-permission eclipse-eclox-download.sh 0755
eclipse-eclox.noarch: I: checking
+ package name ok 
+ spec filename ok
+ license ok
+ license match ok
+ upstream COPYING provided (link to website)
+ specfile in english and legible
+ source from SVN
+ BR okown all directories that it creates
+ build ok F11.x86_64
+ no locale
+ no shared library (no -devel needed)
+ own all directories that it creates
+ defattr ok
+ clean ok
+ macros ok
+ only code
+ small doc (no split needed, not required to run)
+ no desktop needed
+ not own files or directories already owned by other packages
+ install start with clean
+ all file are UTF8
+ build in mock (fedora-rawhide-x86_64)
+ package install and run 

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.