[Bug 501660] Review Request: mrepo - A tool to set up a yum/apt mirror from various sources

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501660


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #5 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-12 06:14:26 EDT ---
(In reply to comment #3)
> The spec file you've referenced above is still for the old version, please
> always upload new spec files together with new srpms.  

You probably just didn't refresh your browser.

(In reply to comment #4)
> - There's no yam package to obsolete.

mrepo used to be called yam. The spec is from Dag Wieer's repository. Maybe I
can remove the obsolete, since the renamal happened a long time ago.

> - Why are there empty python files?

Good question. I wouldn't remove them, though, since that might break
something.

> * MUST: Each package must consistently use macros.
> 
> - Please use %{__rm}, %{__perl}, %{__cat} and %{__make}.

This refers to ($RPM_BUILD_ROOT,$RPM_OPT_FLAGS) vs. (%{buildroot},%{optflags})
- you are not allowed to mix these.

Although using macros for standard commands is not forbidden, IMHO it's bad
style: KISS.


> * SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague,
> and left up to the reviewers judgement to determine sanity.
> 
> - In %preun, why is it /service and not /sbin/service?

Good catch.

> - In %postun, why does it say <script> instead of mrepo?

And this :)

> - Please don't use once &> and once > plus 2>&1 (%preun and %postun).

fixes.

> - Please keep consistent in how you write things within [ ] (%preun and
> %postun).

These are straight from
https://fedoraproject.org/wiki/Packaging/SysVInitScripts


PS. Please mark the items in the review with OK / N/A / NEEDSWORK.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.