[Bug 507943] Review Request: moblin-gtk-engine - GTK engine for Moblin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507943





--- Comment #6 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-13 15:20:03 EDT ---
(In reply to comment #4)
> > MUST: The sources used to build the package must match the upstream source, as
> > provided in the spec URL. NEEDSWORK
> > - Source URL is missing.
> > http://fedoraproject.org/wiki/Packaging/SourceURL
> 
> FIXED: Updated to the moblin git url for source tarballs. Updated to the latest
> release as well. I thought I'd updated this but must have missed it.

If you're using a git tarball, then you need to adjust the version and release
accordingly.
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages

Judging from the URL this seems to be a stable release. However the git part
makes me think this is a daily snapshot. If it is, then you should get the
source from git:
http://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control

> > MUST: Optflags are used and time stamps preserved. NEEDSWORK
> > - Time stamps are lost during install. Adding INSTALL="install -p" as argument
> > to make install should do the trick.
> 
> I couldn't find anything about this in packaging guidelines.

It's sort of implicitly assumed in
https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps

I sent a request to add the mention of it to the FPC.

> > MUST: All relevant items are included in %doc. Items in %doc do not affect
> > runtime of application. NEEDSWORK
> > - Missing WORK.
> 
> Not sure what's missing here. There's no WORK file. I've added the NEWS file.

Ugh. That's what I meant :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.