Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=509609
Ian Weller <ian at ianweller.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #5 from Ian Weller <ian at ianweller.org> 2009-07-13 16:37:11 EDT ---
[ OK ] specfiles match:
1dfdd322b3bfc8a7398306b8ca82061a mediawiki-rss.spec
1dfdd322b3bfc8a7398306b8ca82061a mediawiki-rss.spec.1
[FAILED] source files match upstream:
For some reason your file is missing a single asterisk:
--- mediawiki-rss-1.5/rss.php 2009-07-03 16:21:07.000000000 -0500
+++ blah.php 2009-07-13 15:15:39.347042056 -0500
@@ -1,6 +1,6 @@
<?php
-/*
- *RSS-Feed MediaWiki extension
+/**
+ * RSS-Feed MediaWiki extension
*
* @file
* @ingroup Extensions
[ OK ] package meets naming and versioning guidelines.
It really should be named "mediawiki-RSS" but it doesn't matter all that
much, it's not a hard guideline
[ OK ] spec is properly named, cleanly written, and uses macros consistently.
[ OK ] dist tag is present.
[ OK ] build root is correct.
[ OK ] license field matches the actual license.
[ OK ] license is open source-compatible.
[ N/A ] license text included in package.
[ OK ] latest version is being packaged.
[ OK ] BuildRequires are proper.
[ N/A ] compiler flags are appropriate.
[ OK ] %clean is present.
[ OK ] package builds in mock.
[ OK ] package installs properly.
[ N/A ] debuginfo package looks complete.
[ OK ] rpmlint is silent.
[ OK ] final provides and requires are sane
[ N/A ] %check is present and all tests pass:
[ OK ] no shared libraries are added to the regular linker search paths.
[ OK ] owns the directories it creates.
[ OK ] doesn't own any directories it shouldn't.
[ OK ] no duplicates in %files.
[ OK ] file permissions are appropriate.
[ N/A ] scriptlets match those on ScriptletSnippets page.
[ OK ] code, not content.
[ OK ] documentation is small, so no -docs subpackage is necessary.
[ OK ] %docs are not necessary for the proper functioning of the package.
[ OK ] no headers.
[ OK ] no pkgconfig files.
[ OK ] no libtool .la droppings.
[ N/A ] desktop files valid and installed properly.
Failing on a single asterisk is not enough to make me want to postpone
approval.
------------------------------------------------------------
This package (mediawiki-rss) is APPROVED by me (ianweller)
------------------------------------------------------------
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.