[Bug 491694] Review Request: Anyterm - Web based terminal emulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491694





--- Comment #25 from Mohammed Morsi <mmorsi at redhat.com>  2009-07-14 15:19:05 EDT ---
(In reply to comment #24)
> (In reply to comment #23)
> > (In reply to comment #22)

> 
> > nothing in anyterm explicitly depends on httpd
> > and it can be run 100% fine as is without it.
> 
> > (what are your thoughts about a seperate anyterm-httpd package?)
> 
> Hmm, you're right. A subpackage would be fine. Another option is to just put
> anyterm.conf in %doc since it asks to be edited anyway.
> 

I created a anyterm-httpd subpackage, that depends on anyterm and httpd, and
just contains the anyterm / httpd proxy config.


> > I tried to use all the predefined %{} macros that I could where
> > appropriate
> 
> There's __make, __rm, __mkdir.

Gah, sorry I missed these, updated the spec to use the macro versions.


> > Which way is standard? Googling for this, I find most specs redirect both
> > stdout / stderr
> > (or even just stderr)
> 
> I'd say only redirect stderr if there's a known, harmless error to hide. If
> it's normally silent on stderr then don't redirect it. The same goes for
> stdout, only redirect it if there's anything unsightly to hide.
> 
> getent might send uninteresting output to stdout but is always silent on stderr
> even when the entry is missing. useradd/groupadd is always silent on both
> stdout and stderr. So only redirect stdout from getent and don't redirect
> anything from useradd/groupadd.
> 
> http://fedoraproject.org/wiki/Packaging/UsersAndGroups does it that way.  

Done, useradd and groupadd no longer redirected stderr.

Again thanks for the feedback, new versions uploaded:
http://mohammed.morsi.org/blog/files/anyterm.spec
http://mohammed.morsi.org/blog/files/anyterm-1.1.29-7.fc10.src_.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.