[Bug 506056] Review Request: zikula-module-scribite - The scribite! module for Zikula allows integration of various text editors

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506056





--- Comment #9 from Toshio Ernie Kuratomi <a.badger at gmail.com>  2009-07-15 05:04:26 EDT ---
GOOD:                                                          
* Named according to naming guidelines                         
* specfile named appropriately                                 
* spec file is legible and in English                          
* Package builds on i86                                        
* Package build in koji                                        
* Not a dnamic library                                         
* Not relocatable                                              
* Package owns all directories it creates                      
* Permissions set appropriately                                
* Proper %clean section                                        
* macros used consistently                                     


NEEDSWORK:
* Licensing -- see previous comments
  - The tango images are the only place I found CC licenses.  Perhaps we can
    remove the tango skin?                                                  
* License tag: We can't straighten this out until we figure out what to do  
  about the incompatible licenses but we will want to list the different    
  licenses that things fall under.  So it might look something like this    
  (Please verify/update/add once we figure out how we're going to resolve all
  the licensing problems):                                                   
  License: GPLv2+ and LGPLv2+ and BSD and (GPLv2+ or MPLv1.1+ or LGPL2+) and
MIT
  - And a comment that explains what licenses relate to what files.             
    + Yes, this is painful to audit and record :-(                              
* Source comment needs to be updated in the spec file to reflect the current    
  location.                                                                     
  - http://code.zikula.org/scribite/downloads/19 references an older release    
  - http://code.zikula.org/scribite/downloads/23 does not exist                 
* rpmlint:                                                                      
zikula-module-scribite.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/zikula-module-scribite-3.2/Snoopy_gpl_license.txt
zikula-module-scribite.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/zikula-module-scribite-3.2/changelog.txt
zikula-module-scribite.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/zikula-module-scribite-3.2/tinymce_lgpl_license.txt
zikula-module-scribite.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/zikula-module-scribite-3.2/openwysiwyg_license.txt
zikula-module-scribite.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/zikula-module-scribite-3.2/fckeditor_license.txt
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

These can be fixed with dos2unix or sed:

%{__sed} -i 's/\r//' pndocs/changelog.txt pndocs/Snoopy_gpl_license.txt
pndocs/tinymce_lgpl_license.txt pndocs/openwysiwyg_license.txt
pndocs/fckeditor_license.txt

TO RESOLVE IN THE FUTURE:
* There are language files in this package but they aren't standard gettext po
  files.  They are javascript.  We probably want to mark these as belonging to
  the relevant language but we don't have any tools to help with this at the
  moment

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.