[Bug 491694] Review Request: Anyterm - Web based terminal emulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491694





--- Comment #27 from Mohammed Morsi <mmorsi at redhat.com>  2009-07-15 10:45:49 EDT ---
> Cool, though there's
> 
>  * SHOULD: Usually, subpackages other than devel should require the base
> package using a fully versioned dependency.
> 
> It's only a SHOULD. I don't know if it matters.

Changed the anyterm-httpd dependency to  "Requires: %{name} =
%{version}-%{release}"

> 
> > Done, useradd and groupadd no longer redirected stderr.
> 
> Good enough, though the redirect of stdout for those seems superfluous.
> 

Ah srry, thought the example had that, removed.

> 
> Also, some new rpmlints:
> 
> anyterm.src:111: E: files-attr-not-set
> I think you need a defattr for each subpackage.

Done.

> 
> anyterm.src:120: W: macro-in-%changelog doc
> Edit the changelog to say %%doc.

Done.

> 
> anyterm-httpd.i586: W: summary-not-capitalized httpd proxy configuration for
> anyterm
> It seem wrong to capitalize a package name.

Just had to capitalize the first word in the anyterm-httpd documentation

> 
> anyterm-httpd.i586: W: no-documentation
> There's not much documentation to include. It's all on the web site.  

Ya don't think any docs is appropriate here (the package summary / description
pretty much says it all). I slightly reworded the description to be a little
more clear that the package provides a httpd conf

New versions uploaded:
http://mohammed.morsi.org/blog/files/anyterm.spec
http://mohammed.morsi.org/blog/files/anyterm-1.1.29-8.fc10.src_.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.