[Bug 511916] Review Request: dracut-modules-olpc - OLPC initramfs modules
bugzilla at redhat.com
bugzilla at redhat.com
Wed Jul 15 22:22:49 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=511916
Peter Robinson <pbrobinson at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-review?
--- Comment #3 from Peter Robinson <pbrobinson at gmail.com> 2009-07-15 18:22:48 EDT ---
A full review. The only thing blocking is the build in koji and the few minor
bits mentioned above.
Another small one is you can use %{_datadir} instead of %{_prefix}/share/ in
the files section.
+ rpmlint output
rpmlint dracut-modules-olpc.spec dracut-modules-olpc-0.2.1-1.fc11.src.rpm
1 packages and 1 specfiles checked; 0 errors, 0 warnings.
+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
f57a07be5dfce912a7058be7ba6cec30 dracut-modules-olpc-0.2.1.tar.bz2
? package successfully builds on at least one architecture
tested using koji scratch build
? BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun+ does not use Prefix: /usr
n/a package owns all directories it creates
n/a no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8
Optional:
n/a if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if
available
? reviewer should build the package in mock/koji
? the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
+ scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list