[Bug 511938] Review Request: cld - Coarse locking daemon
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jul 16 08:30:41 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=511938
Fabian Affolter <fabian at bernewireless.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fabian at bernewireless.net
--- Comment #1 from Fabian Affolter <fabian at bernewireless.net> 2009-07-16 04:30:40 EDT ---
Some quick comments on this spec file too.
- You are mixing '$RPM_BUILD_ROOT' and '%{buildroot}' (as in #511941)
- 'Source0' should point to the upstream location of the source tarball.
https://fedoraproject.org/wiki/Packaging/SourceURL
If this is not possible add a comment about how the checkout from the VCS was
done.
- 'Requires: pkgconfig' is missing in the -devel package
https://fedoraproject.org/wiki/Packaging:Guidelines#Pkgconfig_Files
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list