[Bug 512106] Review Request: rpmconf - Tool to handle rpmnew and rpmsave files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512106


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi
         AssignedTo|nobody at fedoraproject.org    |jussi.lehtola at iki.fi




--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-16 07:49:44 EDT ---
- Change 
 BuildRequires: /usr/bin/docbook2man
to
 BuildRequires: docbook-utils
as that package provides the binary at least on F-11 and EL-5.

- Change
 /usr/bin/docbook2man rpmconf.sgml
 /usr/bin/gzip rpmconf.8
to
 docbook2man rpmconf.sgml
(rpm will automatically compress the man page)

- and you can shorten
 mkdir -p $RPM_BUILD_ROOT/%{_mandir}/man8
 mkdir -p $RPM_BUILD_ROOT/%{_usr}/sbin
 install -m 755 rpmconf $RPM_BUILD_ROOT%{_usr}/sbin
 install -m 644 rpmconf.8.gz $RPM_BUILD_ROOT%{_mandir}/man8/
to
 install -D -p -m 755 rpmconf $RPM_BUILD_ROOT%{_sbindir}/rpmconf
 install -D -p -m 644 rpmconf.8 $RPM_BUILD_ROOT%{_mandir}/man8/rpmconf.8
N.B. the use of the %{_sbindir} macro.

- Also, you could write out the file names in %files, i.e.
 %{_sbindir}/rpmconf
 %{_mandir}/man8/rpmconf.8.*
(a wildcard is used for the man page in case the compression format is changed
in the future)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.