[Bug 512228] Review Request: (Previously Orphaned) dumpasn1 - ASN.1 object dump utility
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jul 16 19:35:24 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512228
Ville Skyttä <ville.skytta at iki.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |ville.skytta at iki.fi
Flag| |fedora-review+
--- Comment #1 from Ville Skyttä <ville.skytta at iki.fi> 2009-07-16 15:35:23 EDT ---
Approved, just a couple of remarks:
I'd personally use a patch for the BYTE -> char change, it's less fragile that
way on future updates.
sed -e 's/\r//g' %{SOURCE1} > dumpasn1.cfg
This is no longer necessary, the 20090531 dumpasn1.cfg already has Unix line
endings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list