[Bug 507089] Review Request: olpc-powerd - power management for the XO laptop

bugzilla at redhat.com bugzilla at redhat.com
Thu Jul 16 23:27:12 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507089





--- Comment #5 from Christoph Wickert <fedora at christoph-wickert.de>  2009-07-16 19:27:11 EDT ---
One more thing: The rm -rf in %preun is not nice and causes an rpmlint warning.
We should let the package own the file, then rpm will remove it:

%install
...
mkdir -p $RPM_BUILD_ROOT%{_localstatedir}/run

...
touch $RPM_BUILD_ROOT%{_localstatedir}/run/powerevents

%files
...
%ghost(missingok) %{_localstatedir}/run/powerevents

IMO this is the best solution, but we don't have a guideline for files in
/var/run. On my machine half of the files is owned by a package, the others are
not. I think I should ask packaging committee about this and/or write a
proposal.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list