[Bug 510982] Review Request: psimedia - Audio and video RTP services for Psi-like IM clients

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510982


Peter Lemenkov <lemenkov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #9 from Peter Lemenkov <lemenkov at gmail.com>  2009-07-17 04:17:42 EDT ---
REVIEW:

+ rpmlint is silent

[petro at Workplace ~]$ rpmlint Desktop/psimedia-1.0.3-2.fc11.i586.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[petro at Workplace ~]$

+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual license.
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources, used to build the package,  matches the upstream source, as
provided in the spec URL.

[petro at Sulaco SOURCES]$ sha256sum psimedia-1.0.3.tar.bz2*
019d18034fa94299d896448841d129fd1bad5f58daeb2aba7be540a7d06fb23b 
psimedia-1.0.3.tar.bz2
019d18034fa94299d896448841d129fd1bad5f58daeb2aba7be540a7d06fb23b 
psimedia-1.0.3.tar.bz2.1
[petro at Sulaco SOURCES]$

+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.

http://koji.fedoraproject.org/koji/taskinfo?taskID=1481404

+ All build dependencies are listed in BuildRequires.
+ The package does not list a file more than once in the spec file.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissable content.
+ Everything, the package includes as %doc, does not affect the runtime of the
application.
+ The package does NOT contain any .la libtool archives.
+ The package includes a %{name}.desktop file, and this file is properly
installed with desktop-file-install in the %install section.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8

I don't see any issues here, except that F-10 and F-11 branches still ships
with Psi 0.12. So, let's wait while Psi in these two branches will be updated
(ETA is July 26th, according to Justin's Karneges message in psi-devel).

Anyway, this package is

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.