[Bug 506339] Review Request: XZ Utils - LZMA Utils with newer file format

bugzilla at redhat.com bugzilla at redhat.com
Fri Jul 17 16:52:22 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506339





--- Comment #25 from Bill Nottingham <notting at redhat.com>  2009-07-17 12:52:21 EDT ---
OK, new files:

http://notting.fedorapeople.org/review/xz.spec
http://notting.fedorapeople.org/review/xz-4.999.8-0.7.beta.fc11.src.rpm

> Builds fine; rpmlint says:
>   xz.x86_64: W: name-repeated-in-summary XZ
> Generally I'd just suggest dropping "XZ Utils" from the summary, but it's not a
> big deal.

Fixed.

>   xz.x86_64: W: incoherent-version-in-changelog 4.9999.8-0.6.beta 
>    ['4.999.8-0.6.beta.fc12', '4.999.8-0.6.beta']
> There's an extra '9' in the changelog entry.

Fixed.

> There's a test suite present.  I tried it and it fails utterly, though it
> passes when I build the package locally.   I suspect this is related to the
> rpath issues, so I went with the following:
>   %check
>   LD_LIBRARY_PATH=$PWD/src/liblzma/.libs make check
> and it worked fine.   I think it's a good idea the test suite if at all
> possible, and it seems possible.

Added.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list