[Bug 512273] Review Request: php-pear-File-Bittorrent2 - Decode and Encode data in Bittorrent format

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512273


Paul W. Frields <stickster at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(david at gnsa.us)




--- Comment #3 from Paul W. Frields <stickster at gmail.com>  2009-07-17 14:34:24 EDT ---
[  OK  ] specfiles match:
  211e7e1e97cc16f38cd3a72981f1e0019cc4e958ff096744efdd659dcd818d75 
php-pear-File-Bittorrent2.spec
  211e7e1e97cc16f38cd3a72981f1e0019cc4e958ff096744efdd659dcd818d75 
rpmbuild/SPECS/php-pear-File-Bittorrent2.spec
[  OK  ] source files match upstream:
  674d354ca7a03de5f2020ad9ec2779f1a17c5c6e38d002964f7dfc0684a656eb 
File_Bittorrent2-1.3.1.tgz
  674d354ca7a03de5f2020ad9ec2779f1a17c5c6e38d002964f7dfc0684a656eb
File_Bittorrent2-1.3.1.tgz
[  OK  ] package meets naming and versioning guidelines.
[  OK  ] spec is properly named, cleanly written, and uses macros consistently.
  I'd make the %description paragraph easier to read, but that's totally
subjective.
[  OK  ] dist tag is present.
[  OK  ] build root is correct.
[  OK  ] license field matches the actual license.
[  OK  ] license is open source-compatible.
[  N/A ] license text included in package.
[  OK  ] BuildRequires are proper.
[  N/A ] compiler flags are appropriate.
[  OK  ] %clean is present. 
[  OK  ] package builds in mock.
[  OK  ] package installs properly.
[  N/A ] debuginfo package looks complete.
[  OK  ] rpmlint is silent.
[  OK  ] final provides and requires are sane
[FAILED] %check is present and all tests pass:
  Needs to Buildreq: php-pear-PHPUnit, so tests can be run; then add a %check
section with the following:
  cd %{pear_name}-%{version}
  php -f Tests/AllTests.php
[  N/A ] no shared libraries are added to the regular linker search paths.
[  OK  ] owns the directories it creates. 
[FAILED] doesn't own any directories it shouldn't.
  Should not own %{pear_phpdir}/{test,doc}
[  OK  ] no duplicates in %files.
[  OK  ] file permissions are appropriate.
[  N/A ] scriptlets match those on ScriptletSnippets page.
[  OK  ] code, not content.
[  OK  ] documentation is small, so no -docs subpackage is necessary.
[  OK  ] %docs are not necessary for the proper functioning of the package.
[  OK  ] no headers.
[  OK  ] no pkgconfig files.
[  OK  ] no libtool .la droppings.
[  OK  ] desktop files valid and installed properly.

I would remove the %files line for %{pear_phpdir}/* and replace it with the
following lines:
%{pear_phpdir}/File
%{pear_test}/%{pear_name}

Once that's done I can approve.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.